Changed compare_days to use english date format#248
Open
depiction wants to merge 1 commit intolongbill:masterfrom
Open
Changed compare_days to use english date format#248depiction wants to merge 1 commit intolongbill:masterfrom
depiction wants to merge 1 commit intolongbill:masterfrom
Conversation
…from appearing invalid in arabic with startDate set
Collaborator
|
Thanks, can you provide a "demo" of this approach in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if using moment-with-locales.js, startDate set, and lang set to "ar" (arabic), the compare_days function always returns -1. Therefore, all dates in the datepicker are invalid except the current day.
moment(m1).format('YYYYMM') returns a date format in arabic and parseInt is unable to parse it into an integer, so it returns NaN. To resolve this, always get the date for comparison in an English based date format.