Skip to content

Improvement on loader 6 #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 23, 2014
Merged

Improvement on loader 6 #12

merged 3 commits into from
Aug 23, 2014

Conversation

OxyDesign
Copy link
Contributor

Improvement on circular path (location computed with sin & cos) and more/different steps to have a better transformation (closer to a real circle), as asked in #11.
I only made changes in the Less file (.css and .html are generated).
Feel free to tell me if it's not suitable.

@lukehaas
Copy link
Owner

Thanks for doing this, but there is currently an issue with the spacing of the box-shadows. In my original the box-shadows get a much wider spacing at the peak of the transition. This is an aspect I'd like to maintain for this loader.

@OxyDesign
Copy link
Contributor Author

Ok I see. I changed it a little bit. Is it enough ? Thank you

@lukehaas
Copy link
Owner

Thanks again, it's just a little off still. If you imagine the loader as a clock face the peak of the transition, when the box shadows are most spaced, needs to be at 6 o'clock. Also, the box-shadows are now just a little too spaced out at their peak.

@OxyDesign
Copy link
Contributor Author

Ok and now ?

lukehaas added a commit that referenced this pull request Aug 23, 2014
@lukehaas lukehaas merged commit cb529d0 into lukehaas:step2 Aug 23, 2014
@OxyDesign
Copy link
Contributor Author

Thanx

@lukehaas
Copy link
Owner

Thanks for all your work on this.
I made some additional tweaks to alter the timing.

@OxyDesign
Copy link
Contributor Author

My pleasure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants