Add "no-submit" rule

Disallows `$(form).submit()` expressions in favor of dispatchEvent +
native `form.submit()`.

Author: mislav

index.js

@@ -36,6 +36,7 @@ module.exports = {
     'no-serialize': require('./rules/no-serialize'),
     'no-show': require('./rules/no-show'),
     'no-slide': require('./rules/no-slide'),
+    'no-submit': require('./rules/no-submit'),
     'no-text': require('./rules/no-text'),
     'no-toggle': require('./rules/no-toggle'),
     'no-trigger': require('./rules/no-trigger'),
@@ -80,6 +81,7 @@ module.exports = {
         "jquery/no-size": 2,
         "jquery/no-sizzle": 2,
         "jquery/no-slide": 2,
+        "jquery/no-submit": 2,
         "jquery/no-text": 2,
         "jquery/no-toggle": 2,
         "jquery/no-trigger": 2,

rules/no-submit.js

@@ -0,0 +1,21 @@
+'use strict';
+
+const utils = require('./utils.js')
+
+module.exports = function(context) {
+  return {
+    CallExpression: function(node) {
+      if (node.callee.type !== 'MemberExpression') return
+      if (node.callee.property.name !== 'submit') return
+
+      if (utils.isjQuery(node)) {
+        context.report({
+          node: node,
+          message: 'Prefer dispatchEvent + form.submit() to $.submit'
+        })
+      }
+    }
+  }
+}
+
+module.exports.schema = []

tests/no-submit.js

@@ -0,0 +1,34 @@
+'use strict';
+
+const rule = require('../rules/no-submit')
+const RuleTester = require('eslint').RuleTester
+
+const error = 'Prefer dispatchEvent + form.submit() to $.submit'
+
+const ruleTester = new RuleTester()
+ruleTester.run('no-submit', rule, {
+  valid: [
+    'submit()',
+    '[].submit()',
+    'form.submit()',
+    'form.submit'
+  ],
+  invalid: [
+    {
+      code: '$("form").submit()',
+      errors: [{message: error, type: 'CallExpression'}]
+    },
+    {
+      code: '$form.submit()',
+      errors: [{message: error, type: 'CallExpression'}]
+    },
+    {
+      code: '$("form").first().submit()',
+      errors: [{message: error, type: 'CallExpression'}]
+    },
+    {
+      code: '$("form").append($("input").submit())',
+      errors: [{message: error, type: 'CallExpression'}]
+    }
+  ]
+})