JS Grammar Updates #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix bug in hex-color that uses invalid token - Generate runtime manifest file to avoid dynamic imports
|
Looks good. @mahirshah thoughts? |
mahirshah
approved these changes
Oct 10, 2017
chriseppstein
pushed a commit
that referenced
this pull request
Oct 16, 2017
Fix Script to Format Json Grammars into Ohm Grammars
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pathlibrary instead of string concat for path resolutionhex-color.jsonused a token not present in the lexer, it caused some issues!It is better convention to use
pathin node to construct filepaths. Looks cleaner and avoids pesky string concatenation complexities (stray/s,..s, etc).The new
index.jsgenerated in thegenerateddirectory allows us to import JS grammars without constructing the import path dynamically. So:becomes:
The presence of this manifest file allows bundlers to package all js grammars into a client side runtime. By referencing the manifest file, all grammars will be bundles. By avoiding dynamic input paths, the runtime is able to be statically analyzed by package bundlers.