Skip to content

Added display rules for 600px 768px 992px and 200px breakpoints - #19

Merged
manuel12 merged 3 commits into
manuel12:masterfrom
pulkitxm:display_rules_for_600px_768px_992px_and_1200px_breakpoints
Jun 28, 2023
Merged

Added display rules for 600px 768px 992px and 200px breakpoints#19
manuel12 merged 3 commits into
manuel12:masterfrom
pulkitxm:display_rules_for_600px_768px_992px_and_1200px_breakpoints

Conversation

@pulkitxm

Copy link
Copy Markdown
Contributor

solved #11

@manuel12
manuel12 self-requested a review June 27, 2023 15:33

@manuel12 manuel12 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @pulkitxm this one seems to be missing some rules.

To clarify: all breakpoints(600px / 768px / 992px / 1200px) must have the following classes:

.d-flex {
  display: flex;
}

.d-block {
  display: block;
}

.justify-space-around {
  justify-content: space-around;
}

.justify-space-between {
  justify-content: space-between;
}

.overflow-hidden {
  overflow: hidden;
}

.object-cover {
  object-fit: cover;
}

With the appropriate prefixes for each class:

  • 600px: sm
  • 768px: md
  • 992px: lg
  • 1200px: xl

@manuel12 manuel12 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job. Approved!

@manuel12
manuel12 merged commit 6076381 into manuel12:master Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants