Skip to content

Added border rules for 600px 768px 992px and 1200px breakpoints - #22

Merged
manuel12 merged 3 commits into
manuel12:masterfrom
pulkitxm:border_rules_for_600px_768px_992px_and_1200px_breakpoints
Jun 29, 2023
Merged

Added border rules for 600px 768px 992px and 1200px breakpoints#22
manuel12 merged 3 commits into
manuel12:masterfrom
pulkitxm:border_rules_for_600px_768px_992px_and_1200px_breakpoints

Conversation

@pulkitxm

Copy link
Copy Markdown
Contributor

solved #10

@manuel12 manuel12 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The border classes on this file don't seem to have the requested prefixes. Instead they have the original class names. Also the 768px media query doesn't seem to be added.

@manuel12 manuel12 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now the media queries are not written well. They should be @media screen and (min-width: [resolution]).

Also at the moment the prefixes are not correct:

For the min-width: 600px media query border has no prefixes when it should have sm.

On line 161 there is a repeated min-width: 600px media query. Media queries should not be repeated.

And also the classes inside this query have md prefix when they should have sm.

The next media query min-width: 768px has prefix lg when it should be md.

The next media query min-width: 992px has prefix xl when it should be lg.

The next media query min-width: 1200px has prefix xxl when it should be xl.

@pulkitxm pulkitxm left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

solved #22

@manuel12 manuel12 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, approved!

@manuel12
manuel12 merged commit 46f626d into manuel12:master Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants