Padding rules for 600px 992px and 1200px breakpoints - #23
Merged
manuel12 merged 4 commits intoJun 29, 2023
Merged
Conversation
manuel12
requested changes
Jun 28, 2023
manuel12
left a comment
Owner
There was a problem hiding this comment.
The correct prefix for 992px breakpoint is lg. Right now it's md.
The correct prefix for 1200px breakpoint is lg. Right now it's xl.
Please update these and I will review again.
manuel12
requested changes
Jun 28, 2023
manuel12
left a comment
Owner
There was a problem hiding this comment.
Right now the min-width: 1200px media query has prefix xxl when it should be xl.
pulkitxm
commented
Jun 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
solved #12