Skip to content
This repository was archived by the owner on Aug 14, 2021. It is now read-only.

Custom Positioning. #19

Merged
merged 4 commits into from
May 28, 2013
Merged

Custom Positioning. #19

merged 4 commits into from
May 28, 2013

Conversation

jdaltemus
Copy link
Contributor

Thanks for allowing me to help with creating the custom positioning. Sorry, I did not think about running the code through something like jshint. I will do that next time.

Please include the change into the main branch at your earliest convenience and let me know so I can pull the official one when it is ready.

Below is the the contribution information you requested:

My full name is "Jeffrey Dean Altemus"

Please use my FOSS email: "foss@teamaltemus.net"

Use my personal URL: http://jeff.teamaltemus.net

I am just starting to create my personal URL, so there is just a shell their right now. I am working on selecting a theme and creating some customization.

Best Wishes,
Jeff

@mar10
Copy link
Owner

mar10 commented May 25, 2013

Hi,

If you install node.js, then run npm install from the source folder you can run grunt which will do a jshint and unit testing.
If you look at your pull request
#19
you see that travis is configured to do this for every checkin (and pull request)
https://travis-ci.org/mar10/jquery-ui-contextmenu/builds/7492614

I am new to grunt and github myself and am still learning this, but I think it's pretty cool.

The jshint warnings are no big deal, and I can easily fix it.
I just mention it because I thought you might be interested to try this yourself.

Otherwise I will merge shortly.
Thanks for you help!

mar10 added a commit that referenced this pull request May 28, 2013
@mar10 mar10 merged commit 54585de into mar10:master May 28, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants