Skip to content
This repository was archived by the owner on Aug 14, 2021. It is now read-only.

Support for jquery ui 1.11 #61

Merged
merged 7 commits into from
Jul 6, 2014
Merged

Conversation

gvas
Copy link
Contributor

@gvas gvas commented Jul 2, 2014

jQuery UI 1.11 removed the requirement to use anchors in menu items. Markup containing anchors will still work, but there are styling issues. This PR adds support for initialization of the menu from an anchor-less HTML markup.

A breaking change is that the menu command was moved from the <a> element's href attribute to the data-command attribute of the <li> element.

@mar10
Copy link
Owner

mar10 commented Jul 4, 2014

très cool. I'll look into it over the weekend, but I noticed that in the demo/index.html the icons seem to be broken when I include this:

    <link type="text/css" rel="stylesheet" href="https://code.jquery.com/ui/1.11.0/themes/ui-lightness/jquery-ui.css" />
    <script src="https://ajax.googleapis.com/ajax/libs/jquery/1/jquery.min.js" type="text/javascript"></script>
    <script src="https://code.jquery.com/ui/1.11.0/jquery-ui.min.js" type="text/javascript"></script>

contextmenu with ui 1-11

@gvas
Copy link
Contributor Author

gvas commented Jul 4, 2014

The themeswitcher must also be configured to load the correct stylesheet:

    $("#switcher").themeswitcher({
        jqueryuiversion: "1.11.0",
        imgpath: "../lib/Super-Theme-Switcher/images/",
        loadTheme: "Smoothness"
    });

mar10 added a commit that referenced this pull request Jul 6, 2014
@mar10 mar10 merged commit 479e964 into mar10:master Jul 6, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants