min-height/max-height not working

[dennismueller]

Hi!
I have a problem with the attributes min-height and max-height. They just don't work. The min-width and max-width are working as intended.
I did a little bit of research and code digging and found a solution:

before:

if ('string' === typeof rules) {
                rules = rules.toLowerCase();
                if (-1 !== rules.indexOf('min-width') || -1 !== rules.indexOf('max-width')) {
                    extractQuery(rules);
                }
            } else {
                for (var i = 0, j = rules.length; i < j; i++) {
                    if (1 === rules[i].type) {
                        selector = rules[i].selectorText || rules[i].cssText;
                        if (-1 !== selector.indexOf('min-width') || -1 !== selector.indexOf('max-width')) {
                            extractQuery(selector);
                        }
                    } else if (4 === rules[i].type) {
                        readRules(rules[i].cssRules || rules[i].rules);
                    }
                }
            }

In my opinion the if statement for height is missing. So I did the following changes and now it works like a charm.

after:

 if ('string' === typeof rules) {
                rules = rules.toLowerCase();
                if (-1 !== rules.indexOf('min-height') || -1 !== rules.indexOf('max-height')) {
                    extractQuery(rules);
                }else if (-1 !== rules.indexOf('min-width') || -1 !== rules.indexOf('max-width')){
                    extractQuery(rules);
                }
            } else {
                for (var i = 0, j = rules.length; i < j; i++) {
                    if (1 === rules[i].type) {
                        selector = rules[i].selectorText || rules[i].cssText;
                        if (-1 !== selector.indexOf('min-height') || -1 !== selector.indexOf('max-height')) {
                            extractQuery(selector);
                        }else if(-1 !== selector.indexOf('min-width') || -1 !== selector.indexOf('max-width')) {
                            extractQuery(selector);
                        }
                    } else if (4 === rules[i].type) {
                        readRules(rules[i].cssRules || rules[i].rules);
                    }
                }
            }

Maybe there's another, cleaner way to fix this?

Greetz,

Dennis

[marcj]

Oh, obviously yes. Do you want to provide a PR?

[dennismueller]

Sorry for the delay.
I've created the pull request.

Greetz,

Dennis