ResizeSensor not functioning on IE8 after changes made since 0.0.2

I confirmed that with tag 0.0.2, IE8 (using modern.IE) functions correctly and IE11 (also modern.IE) fails, as stated. With the same browser setup coupled with the software from master @ 0975de5, IE11 appears to function correctly but IE8 no longer functions. Confirmed the above in my test bench and using the last demo (demo #5?) in test\index.html. Chrome, Firefox, & Safari operate correctly with both versions. I didn't try IE9 or IE10.

The commit logs indicate that support for IE11 was added, and inspecting the source code reveals that ResizeSensor.js in master @ 0975de5 was largely rewritten since 0.0.2.

BTW, I appreciate that the nature of the work you are doing here is difficult… Ganbatte!

[marcj]

dev-masters works in all browser on my machines.

[marcj]

Which tests did you use?

Well, here are the steps I used to reproduce the issue. I have two tests, the tests provided in this Git repo and a separate test bench I built myself, incorporating this into some larger body of work. Both tests exhibit the same success and failure cases.

---- 8< ---- 8< ----

Steps to reproduce failure in IE8 with master @ 0975de5:
git checkout master
test\index.html (Opens the test in HTML in IE)

Steps to reproduce success in IE8 with 0.0.2:
git checkout master (Copy the test HTML from master into 0.0.2)
copy test\index.html
git checkout 0.0.2
mkdir test
move \index.html test
test\index.html (Opens the test HTML in IE)

When loading content in IE, I Shift-reload to flush caches, and then IE reloaded by itself once more after I allowed "dynamic content" to run in the warning bar that appears)

After opening the test HTML, I examine the last (unnumbered) demo (Demo #5?) in the page. Note that the first 4 demos all don't function in IE8 as well as they do in other browsers.

The IE8 was downloaded as a VM from Microsoft's modern.IE site, WinXP IE8 build 20131127 for VirtualBox for Mac, here: https://www.modern.ie/en-us/virtualization-tools#downloads
Menu → Help → About Internet Explorer reports:
Version: 8.0.6001.18702
Update Versions: 0

Hope this helps

Not sure if this is related, but when running the test in IE8 with master, I noticed that an error was printed out on the Developer Tools console: "Object doesn't support this property or method ElementQueries.js, line 157 character 44".

[marcj]

Ok cool, thanks. I'm going to try to reproduce this tomorrow.

[marcj]

haven't found time yet, sorry.

[ajmueller]

I too ran into the issue that @vivid-inc mentioned in their last comment. IE8 has support for querySelectorAll, but not the bind function contained therein on other browsers.

EDIT: I've closed that PR as it didn't fix IE8 completely, it simply resolved the specific error @vivid-inc saw on line 157. For what it's worth, changing that line to this resolves that one error:

if (document.querySelectorAll.bind) query = document.querySelectorAll.bind(document);

@marcj Just a ping to check if you have an ETA on this issue?

[marcj]

@vivid-inc, no, I don't have an ETA.

[o-nix]

Huh, so it doesn't actually work now?

[marcj]

@vivid-inc does @ajmueller's fix resolve your issue?

@marcj Don't have an answer for you, sorry. We had to move past this issue, so for IE8 we set a listener for jquery's resize() event on the window. Sub-optimal perhaps, but still effective.

On 2015 Jan 14, at 01:28, "Marc J. Schmidt" notifications@github.com wrote:

@vivid-inc does @ajmueller's fix resolves your issue?

—
Reply to this email directly or view it on GitHub.

[erikwinlof]

I found a similar issue when testing IE9 (using virtual box and an image from modern.ie with Windows 8 and IE9) where IE9 never got the "scroll" events. It worked fine for IE11though.

After some digging I found that similar libraries are using the IE proprietary "resize" event on the element when running IE. So I locally patched ResizeSensor.js v0.3.0 to use the "error" event instead of "scroll" (when running IE9) and it all worked fine.