Add support for reading rules from imported CSS style sheet #104
Conversation
also rewrite readRules(..): - potential bug when rules is plain String - use switch/case instead of if..else if
| } | ||
| break; | ||
| case 3: // CSSRule.IMPORT_RULE | ||
| r = r.styleSheet; // then continue to next case statement |
There was a problem hiding this comment.
shouldn't be this 'case' at the first position, right before case 1?
There was a problem hiding this comment.
They're almost equivalent.
It is said that switch/case is more intuitive and easily optimized by JS engine. If count of conditions growing, switch/case usually runs faster than multiple if-else-if.
But position of case 3 and case 4 must not be exchanged, since no break at the end of case 3 which continuing to execute case 4.
@see http://archive.oreilly.com/pub/a/server-administration/excerpts/even-faster-websites/writing-efficient-javascript.html
There was a problem hiding this comment.
It's hard to understand, that's why I prefer not to have switch-case especially when they contain non breaking cases. It appears to me like it's wrong, because you overwrite r in case 3 because there is only case 4 that can react on that case. STYLE_RULE in case 1 is not able to check for that new r.
Basically took the idea on [pull-104](marcj#104) but made only the part that matters for this feature.
No description provided.