Allow standalone .detach function to accept same arbitrary elements as ResizeSensor class
#107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…along .detach function as well
|
LGTM, thanks! :) |
|
No worries, thanks for a super useful piece of code :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
factor out iterating over single or multi elements and reuse in stand alone
.detachfunction as well.Previously, you could pass a single or multiple elements to the
ResizeSensorclass and it would handle that, butResizeSensor.detachcould only handle single elements. This change factors out the code used to handle single or multiple elems and reuses it inResizeSensor.detachas well for improved consistency