Use 'window' if available as 'root' in exporting #151
Conversation
| @@ -12,7 +12,7 @@ | |||
| } else { | |||
| root.ElementQueries = factory(root.ResizeSensor); | |||
| } | |||
| }(this, function (ResizeSensor) { | |||
| }(typeof window !== 'undefined' ? window : this, function (ResizeSensor) { | |||
There was a problem hiding this comment.
@josephschmitt do you have an opinion on that?
There was a problem hiding this comment.
The solution to this specific big report looks fine to me, but I'm curious as to why it's not working the way it's written. The implementation of root was taken right from the UMD example code, so I'd expect this to be a problem with any module using the UMD module pattern.
Any insights in your bugfinding @newlukai?
There was a problem hiding this comment.
Actually now that I look at it I don't think this code should go here. The way it's written it's always favoring window if it's defined, since that typeof check happens before the and or exports checks. I'd suggest moving this to inside the else statement on line 12
There was a problem hiding this comment.
Before the amd check, not and
There was a problem hiding this comment.
I've to confess that I'm pretty new to JavaScript, so I don't exactly know why this isn't working while building my app. But since ResizeSensor isn't the only lib I use, I compared your mechanism with the one of Highcharts which is working fine in our build process.
If you still need more information don't hesitate to bother me ;)
|
Thanks, we'll see how it turns out. |
We use css-element-queries (actually only the ResizeSensor) in a Polymer based app. While we were able to use ResizeSensor in the dev environment, we weren't able to use it in the built artifact created by gulp and Polymer CLI.
The problem was that 'root' was undefined in the exporting part of the ResizeSensor. I accordingly changed ElementQueries.js, but didn't test the change.