Fixed bug that prevented detach from being called on instance #169
Conversation
…hen withTracking was set to true.
|
Good catch, thanks! |
|
My pleasure. Do you have an ETA for the next release? |
|
No, but if you help me to test some browser with the master version I can kick out a release tonight/asap :) |
|
I don't mind helping you out, although I don't have access to a lot of different browsers. Latest Chrome and latest Firefox on Mac; latest chrome on android. Do you have specific test cases I could do? |
|
I have nothing special, I just open the website (https://github.com/marcj/css-element-queries/tree/gh-pages) with newest css-element-queries lib and then try the demos in each browsers. Ususally Firefox, Chrome, Safari, IE 7,8,9,10,11. But I currently don't have windows at hand :) |
|
Cool, I'll see what I can do. Would you be open to adding unit tests in the repo to check for basic functionalities too? |
|
Definitely! :) Wanted to do it already, but time is big factor :( |
|
Finally found someone to help with the tests. |
Detach method on instance is checking for this.withTracking, when it should be checking for trackingActive as defined in the init function. this.withTracking is out of scope in the instance detach method.