Initial hidden state fix #208
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test demo highlight the issue of adding a ResizeSensor when the element is hidden (or a parent in the tree is hidden)
using 'var' in another function will declare a separate new variable, hence messing with the intended logic.
This is more elegant, and will not miss the exact moment when the element become visible, it should not eat much CPU either than the Interval approach (though we should test this).
JeanRemiDelteil
referenced
this pull request
Jan 10, 2018
…co). Removed element tracking. Dropped IE9 and lower support. Fixed sensor bug with invisible elements. Addet reset() method to ResizeSensor.
|
Will this get merged? |
This was referenced Feb 1, 2018
|
Merged in #213 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix ResizeSensor when adding it to an element that is currently hidden,
even if it is hidden because one of its parent is hidden.
Also contain fixes for incorrect logic found when writing this fix.