Skip to content

add max-width of 100% for the resize-sensor element #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2018
Merged

add max-width of 100% for the resize-sensor element #238

merged 1 commit into from
Jul 23, 2018

Conversation

sag1v
Copy link
Contributor

@sag1v sag1v commented Jul 23, 2018

should fix #232

@marcj marcj merged commit e1f3e04 into marcj:master Jul 23, 2018
@marcj
Copy link
Owner

marcj commented Jul 23, 2018

Thanks!

@sag1v
Copy link
Contributor Author

sag1v commented Jul 23, 2018

@marcj No problem.
This is strange though, have you change the resizeSensor behavior lately? because i don't see the new element with the .resize-sensor class being added to the DOM anymore, though everything looks like its working fine.

Tested it with older version and i do see the element being added.

@sag1v
Copy link
Contributor Author

sag1v commented Jul 24, 2018

@marcj Ok i think i got an answer for my question, with this line.

So we are now using the ResizeObserver so no need to append our own element.
On what situations the ResizeObserver wont be available?
if (typeof ResizeObserver !== "undefined") { ...

@marcj
Copy link
Owner

marcj commented Jul 24, 2018

ResizeObserver is new Chrome only

@sag1v
Copy link
Contributor Author

sag1v commented Jul 24, 2018

@marcj Thanks! yeah just found it :)
https://caniuse.com/#feat=resizeobserver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resize-sensor wider than the view port
2 participants