Make the MutationObserver of ResizeSensor compatible with new Chrome version #249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…version The for-in loop over the `NodeList` now goes through the prototype chain, so we check `hasOwnProperty` first
|
Thanks! |
|
holy cow you are fast. any chance you could publish this onto npm? My current PR is blocked because our browser tests are failing due to this bug |
|
I love you - thanks for the insane response times, you put APIs to shame ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The for-in loop over the
NodeListnow goes through the prototype chain, so we checkhasOwnPropertyfirst.Otherwise, we get this cryptic error: