Skip to content

support data- custom HTML attributes #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fabasoft-michael-stedry wants to merge 3 commits into
base: master
Choose a base branch
from
Open

support data- custom HTML attributes #273

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f81e0a7
support data- custom HTML attributes
fabasoft-michael-stedry May 29, 2019
f3d2dd9
support data- custom HTML attributes - test updated to use the new co…
fabasoft-michael-stedry Jun 3, 2019
cca4b21
support data- custom HTML attributes - documentation updated to use t…
fabasoft-michael-stedry Jun 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
support data- custom HTML attributes - documentation updated to use t… 
…he new correct way
  • Loading branch information
@fabasoft-michael-stedry
fabasoft-michael-stedry committed Jun 3, 2019
commit cca4b21f4eb97f2a0ff1b4539a692303250de02b
17 changes: 9 additions & 8 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ Features:
- no CSS modifications. Valid CSS Syntax
- all CSS selectors available. Uses regular attribute selector. No need to write rules in HTML/JS.
- supports and tested in webkit, gecko and IE(10+)
- `min-width`, `min-height`, `max-width` and `max-height` are supported so far
- `data-min-width`, `data-min-height`, `data-max-width` and `data-max-height` are supported so far and
- for backwards compatibility the HTML non-compliant attributes `min-width`, `min-height`, `max-width` and `max-height` are still supported
- works with any layout modifications: HTML (innerHTML etc), inline styles, DOM mutation, CSS3 transitions, fluid layout changes (also percent changes), pseudo classes (:hover etc.), window resizes and more
- no Javascript-Framework dependency (works with jQuery, Mootools, etc.)
- Works beautiful for responsive images without FOUC
Expand All @@ -33,25 +34,25 @@ More demos and information: http://marcj.github.io/css-element-queries/
font-size: 12px;
}

.widget-name[min-width~="400px"] h2 {
.widget-name[data-min-width~="400px"] h2 {
font-size: 18px;
}

.widget-name[min-width~="600px"] h2 {
.widget-name[data-min-width~="600px"] h2 {
padding: 55px;
text-align: center;
font-size: 24px;
}

.widget-name[min-width~="700px"] h2 {
.widget-name[data-min-width~="700px"] h2 {
font-size: 34px;
color: red;
}
```

As you can see we use the `~=` [attribute selector](https://developer.mozilla.org/en-US/docs/Web/CSS/Attribute_selectors).
Since this css-element-queries polyfill adds new element attributes on the DOM element
(`<div class="widget-name" min-width="400px 700px"></div>`) depending on your actual CSS and element's dimension,
(`<div class="widget-name" data-min-width="400px 700px"></div>`) depending on your actual CSS and element's dimension,
you should always use this attribute selector (especially if you have several element query rules on the same element).

```html
Expand All @@ -64,9 +65,9 @@ you should always use this attribute selector (especially if you have several el

```html
<div data-responsive-image>
<img data-src="http://placehold.it/350x150"/>
<img min-width="350" data-src="http://placehold.it/700x300"/>
<img min-width="700" data-src="http://placehold.it/1400x600"/>
<img data-src="http://placehold.it/350x150"/>
<img data-min-width="350" data-src="http://placehold.it/700x300"/>
<img data-min-width="700" data-src="http://placehold.it/1400x600"/>
</div>
```

Expand Down