Fix a race condition where a rapid shrink and expand will cause neither to trigger a change #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er to trigger a change If a user manages to rapidly change both the shrink and expand, then the first one to fire may reset the last width and height causing the other scroll event to fail the change check, incorrectly. By keeping them on separate variables, we prevent this kind of exception.
marcj
added a commit
that referenced
this pull request
Sep 16, 2015
Fix a race condition where a rapid shrink and expand will cause neither to trigger a change
|
thanks, good catch! |
|
Was this reverted by c16cdc9? |
|
Yes, see PR description at #65 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user manages to rapidly change both the shrink and expand, then the first one to fire may reset the last width and height causing the other scroll event to fail the change check, incorrectly. By keeping them on separate variables, we prevent this kind of exception.