Skip to content

Make EQ work with IE/edge #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

jacobjuul
Copy link

IE and Edge parses cssRules with [attributes] differently

@@ -187,10 +187,12 @@
function extractQuery(css) {
var match;
var smatch;
var ieSelector = '.' + css.split('.')[1].trim();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if the rule has no . in it?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point. I haven't tested how IE handles ID's.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcj fixed in new commit

@marcj
Copy link
Owner

marcj commented Oct 16, 2015

Hey cool, thanks! so comma separated rules are OK in IE/Edge now?

@jacobjuul
Copy link
Author

@marcj No they need to be specified individually. But at least it works now. ;)

juneidy added a commit to juneidy/css-element-queries that referenced this pull request Dec 15, 2015
@marcj
Copy link
Owner

marcj commented Dec 21, 2015

Heyho! We've pulled in some code lately which should fix this already. @jacobjuul, can you please confirm that your issue is fixed with current master version?

@marcj marcj closed this May 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants