Avoid non-initialized resize-sensor width/heights. #8
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lly has zero width or height. The underflow will never trigger in these cases otherwise.
|
Mh, I'm not sure about that. Can you create please a test case (jsfiddle) where the current resize-sensor fails? |
|
Me an jsfiddle don't get along, so I rather explain the logic error that was fixed. If the height variable is initialized to 0 and the resize sensor initially is zero-height. What will happen in the setupSensor the first time it is called? Neither firstStyle or lastStyle will be initialized. Resize of the main resizeSensor will not trigger overflow (since resizeSensor cannot become less than 0 in height. Also the underflow will not trigger since it is already the same size or less than the resizeSensor. |
marcj
pushed a commit
that referenced
this pull request
Jan 26, 2014
Avoid non-initialized resize-sensor width/heights.
|
Ok, makes sense to me. Thanks for the explantation and pr! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue when an element initially has zero width or height. The initialization does not set the resize-sensor-underflow to correctly pick up resize events in these cases. Additionally Firefox and Chrome seems to optimize away any underflow event to a div with no area.
The fix makes sure that the resize-sensors will get intializes correctly. It would be possible to initialize to 'null' instead, but then the comparisons afterwards needs to be a bit more strict.