Work with aggressive CSS transitions #83
Conversation
|
Hey! Very nice found, thanks for your contributions. Unfortunately I've merged another PR which broke this one in the way I can't merge it through github. Could you please rebase your pull-request? :) I would very like to merge this beauty. |
|
Here it is. I think 30px are not needed anymore (1px might be enough), yet I find it to be a safe value. |
|
Would you like to adjust your pull-request to 1px? |
If its size update were animated, the element could become smaller than its parent, thus making impossible to scroll 'expand' to bottom on further 'scroll' events and breaking the sensor.
|
Even better: I've tested it again with the fix to #63 and there's no more need for extra space, any 1px change is correctly detected starting from an empty sensor. |
|
Oh that sounds perfect, then we could close this PR? :) |
|
Yeah, please, pull it in. :) |
|
I actually meant with closing this PR that we're not going to merge it :D I thought there's no need anymore. Does |
|
Sure it does, as expressed in the text above and in the commit message. ;) |
Work with aggressive CSS transitions
|
Alright, here we go. Thanks! |
Allow the sensor to work on very small elements (usually it needs to wait for some size to be reached, at least scrollbar width). Also, prevent 'expand' child from inheriting CSS transitions (which would possibily break the sensor by animating its size updates).