getEmSize had wrong Syntax for 'getComputedStyle' #93
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
• The function getEmSize had a wrong Syntax for 'getComputedStyle', the 2nd parameter is only for pseudo selectors and it will return all styles, see [docs](https://developer.mozilla.org/en-US/docs/Web/API/Window/getComputedStyle?redirectlocale=en-US&redirectslug=DOM%2Fwindow.getComputedStyle) • The function convertToPx did not work for floats, I guess ... E.g. `1.8rem`'s units became '.8rem' and so the switch failed... Corrected both.
|
Good catch, thank you! :) |
marcj
added a commit
that referenced
this pull request
Feb 17, 2016
getEmSize had wrong Syntax for 'getComputedStyle'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the 2nd parameter is only for pseudo selectors and it will return all styles, see docs
E.g.
1.8rem's units became '.8rem' and so the switch failed...Corrected both...