Skip to content

Commit ce33493

Browse files
vanshikaaroramaskaravivek
authored andcommitted
Refactor asynctasks to Rxjava implementation (commons-app#2707)
1 parent 671e305 commit ce33493

File tree

5 files changed

+173
-282
lines changed

5 files changed

+173
-282
lines changed

app/src/main/java/fr/free/nrw/commons/di/ActivityBuilderModule.java

-1
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,6 @@ public abstract class ActivityBuilderModule {
6565
@ContributesAndroidInjector
6666
abstract BookmarksActivity bindBookmarksActivity();
6767

68-
6968
@ContributesAndroidInjector
7069
abstract ReviewActivity bindReviewActivity();
7170
}

app/src/main/java/fr/free/nrw/commons/di/CommonsApplicationComponent.java

+3-7
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,9 @@
1212
import fr.free.nrw.commons.contributions.ContributionsSyncAdapter;
1313
import fr.free.nrw.commons.delete.DeleteTask;
1414
import fr.free.nrw.commons.modifications.ModificationsSyncAdapter;
15-
import fr.free.nrw.commons.review.CheckCategoryTask;
16-
import fr.free.nrw.commons.review.SendThankTask;
15+
import fr.free.nrw.commons.review.ReviewController;
1716
import fr.free.nrw.commons.settings.SettingsFragment;
1817
import fr.free.nrw.commons.nearby.PlaceRenderer;
19-
import fr.free.nrw.commons.settings.SettingsFragment;
2018
import fr.free.nrw.commons.upload.FileProcessor;
2119
import fr.free.nrw.commons.widget.PicOfDayAppWidget;
2220

@@ -45,12 +43,10 @@ public interface CommonsApplicationComponent extends AndroidInjector<Application
4543

4644
void inject(DeleteTask deleteTask);
4745

48-
void inject(CheckCategoryTask checkCategoryTask);
49-
50-
void inject(SendThankTask sendThankTask);
51-
5246
void inject(SettingsFragment fragment);
5347

48+
void inject(ReviewController reviewController);
49+
5450
@Override
5551
void inject(ApplicationlessInjection instance);
5652

app/src/main/java/fr/free/nrw/commons/review/CheckCategoryTask.java

-129
This file was deleted.

0 commit comments

Comments
 (0)