Skip to content

Refactor asynctasks to Rxjava implementation #2707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2019

Conversation

vanshikaarora
Copy link
Contributor

Description (required)

Refactored asynctasks to Rxjava implementation

Fixes ##2698 Refactor Improve Peer Review

Changes made

  • Deleted classes SendThankTask.java and CheckCategoryTask.java
  • Added RxJava elements instead

@codecov-io
Copy link

Codecov Report

Merging #2707 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2707      +/-   ##
=========================================
+ Coverage    2.71%   2.71%   +<.01%     
=========================================
  Files         268     266       -2     
  Lines       12864   12848      -16     
  Branches     1147    1147              
=========================================
  Hits          349     349              
+ Misses      12489   12473      -16     
  Partials       26      26
Impacted Files Coverage Δ
.../fr/free/nrw/commons/di/ActivityBuilderModule.java 0% <ø> (ø) ⬆️
...a/fr/free/nrw/commons/review/ReviewController.java 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c17a1f9...c600bad. Read the comment docs.

@maskaravivek maskaravivek merged commit ce33493 into commons-app:master Mar 22, 2019
@vanshikaarora
Copy link
Contributor Author

Thanks for approving the PR @maskaravivek :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants