-
-
Notifications
You must be signed in to change notification settings - Fork 106
Inline mode for Timepicker #140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I've currently got an early stage prototype implementation of the material spec time picker, but it doesn't have a modal specification so currently I haven't done anything to that |
By Inline do mean that you can Render the Timepicker to a specific DOM Element? Is this correct or what so you mean? If yes then i need the Same for Datepicker. |
@wuda-io by Inline I mean to render it in a popover (powered by Popper.js), positioned near the focused input field. |
I've been working on this issue and created 2 pull request: Use the plugin with the following options:
|
As for now, timepicker opens as a modal, which is fine for mobile devices. But for desktop it would be a better UX if it would open inline, because that way users don't loose the context (usually some kind of data entry form). Also, it is kind of limiting in situations where picker is in modal already.
See live example at: https://next.material-ui.com/components/time-picker/
My solution:
I suggest using optional tippy.js dropdown solution powered by Popper.js positioning engine. Also would need to implement some kind of mobile detection and I would use a "poke-it" strategy (http://www.stucox.com/blog/you-cant-detect-a-touchscreen/#poke-it) since a user has to touch/click the time icon to open the picker. Maybe anybody can suggest a more robust alternative?
This is a feature request I am filling to contribute to as I am very keen to using this component. Any ideas? Thanks!
The text was updated successfully, but these errors were encountered: