Skip to content

[Accessibility] Feature Discovery open/close not accessible by keyboard interaction #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
Tracked by #543
gselderslaghs opened this issue Dec 7, 2024 · 2 comments
Closed
3 tasks done
Tracked by #543
Labels
enhancement New feature or request

Comments

@gselderslaghs
Copy link
Member

Before submitting...

Context

When using the Feature Discovery component, the element does not seem to be intractable by keyboard

Current Behavior

Open/close button is not tabbable/focusable by keyboard interaction

Expected behavior

Component should be accessible by mouse and keyboard input

Possible Solutions or Causes

Implement the necessary functional attributes on initialization in order to make open/close button tabbable/focusable by keyboard interaction

Your Environment

  • Version used: 2.1.1
@gselderslaghs
Copy link
Member Author

Changelog

  • Implemented keyboard interaction
  • Implemented aria-expanded
  • Implemented tab-index, this also works with child elements inside the tap target container

This feature is ready for review in pull-request #537

@gselderslaghs gselderslaghs changed the title [Accessibility] Feature Discovery open/close not tabbable/focusable by keyboard interaction [Accessibility] Feature Discovery open/close not accessible by keyboard interaction Dec 11, 2024
@gselderslaghs gselderslaghs added the enhancement New feature or request label Dec 12, 2024
@gselderslaghs
Copy link
Member Author

Closing this as fixed in v2.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant