Skip to content

Support to Material Symbols #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
May 30, 2023
Merged

Support to Material Symbols #372

merged 14 commits into from
May 30, 2023

Conversation

mauromascarenhas
Copy link

Proposed changes

Add support to "material-symbols", the newest alternative to "material icons".

What is new:

  • Possibility of using any set of "material-symbols" (outlined, round or sharp) where "material-icons" can be used;
  • Chips can receive a custom "closeIconClass" property if the user wants to use "symbols" instead of "icons" (defaults to "icons");
  • Updated docs so as to include samples in "Icons" page and "closeIconClass" Chips property description:
    • Updated link to "Material Icons" (official font reference page);
    • Included link to "Material Symbols" (official font reference page);
    • Added code samples.
  • "font-family" prioritizes "Material Symbols" falling back to "Material Icons", if not found.

Screenshots (if appropriate) or codepen:

In the following screenshot it is possible to check the usage of a Material Symbol (database) which is not present in "Material Icons" (iconset):

Screenshot of the "database" symbol in different sizes: tiny, small, medium and large

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My commit messages follows the conventional commit format
  • My change requires a change to the documentation, and updated it accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

wuda-io and others added 14 commits April 19, 2023 13:26
@wuda-io
Merge pull request materializecss#359 from materializecss/v2-dev
0aa39f2 
Preperation for 2.0.0 alpha
@wuda-io
ci: fix about page path
d0abf26
@wuda-io
Merge branch 'main' of https://github.com/materializecss/materialize
6fdd54e
@wuda-io
ci: adapt release process to typescript
12f9ee6
@wuda-io
ci: fix Gruntfile for release
1eef53a
@wuda-io
ci: make gruntfile work
d53a92b
@wuda-io
chore: release 2.0.0-alpha
0ada13a
@danice
fix: _theme_variables file was not included in deploy
85e680f
@wuda-io
Merge pull request materializecss#363 from danice/main
76453bf 
fix: _theme_variables file was not included in deploy
@mauromascarenhas
feat(icons): support to material symbols
c4e6e4e 
- Updated CSS rules for the following components:
    - Docs icons (ready for a possible replacement in the future);
    - Optimize legibility (utility for mobile phones);
    - Breadcrumbs;
    - Navbars;
    - Sidenav.
@mauromascarenhas
docs(icons): support to material symbols
dfc0949 
- Updated docs so as to include Material Symbols references and samples;
- Replaced link to "list of icons".
@mauromascarenhas
feat(chips): support to custom close icon
aa694b1 
- Added possibility of setting a different class for "close" button:
    - Added "closeIconClass" property to instance options;
    - "closeIconClass" option defaults to "material-icons".
@mauromascarenhas
docs(chips): support to custom close icon
5bff793 
- Updated docs to include description of "closeIconClass" option.
@wuda-io
docs(icons): fixed intents of code and comments
94fef45
wuda-io
wuda-io previously approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@wuda-io wuda-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, fixed some of the docu and added preview of symbols.

@wuda-io wuda-io changed the base branch from main to v2-dev May 30, 2023 09:56
@wuda-io wuda-io dismissed their stale review May 30, 2023 09:56

The base branch was changed.

@wuda-io wuda-io merged commit d1524ce into materializecss:v2-dev May 30, 2023
@mauromascarenhas mauromascarenhas deleted the material-symbols branch May 30, 2023 18:04
@wuda-io wuda-io mentioned this pull request Jul 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wuda-io wuda-io wuda-io approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mauromascarenhas @wuda-io @danice