Skip to content

Tooltip content #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 28, 2023
Merged

Tooltip content #431

merged 3 commits into from
Oct 28, 2023

Conversation

danice
Copy link

@danice danice commented Oct 24, 2023

Proposed changes

Alternative solution to "[Bug]: Toast html/unsafeHtml not work #394 ". This will allow to specify some element as tooltip content. A new property data-tooltip-id will allow specify an element as tooltip content instead of text.

Screenshots (if appropriate) or codepen:

imagen

will appear as

imagen

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • [ x I have read the CONTRIBUTING document.
  • My commit messages follows the conventional commit format
  • My change requires a change to the documentation, and updated it accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@wuda-io
Copy link
Member

wuda-io commented Oct 26, 2023

Very good idea! I'll check it out...

Copy link
Member

@wuda-io wuda-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wuda-io wuda-io merged commit e999ad0 into materializecss:v2-dev Oct 28, 2023
@wuda-io wuda-io added the hacktoberfest-accepted The PR is a valuable contribution that counts for the Hacktoberfest Event label Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted The PR is a valuable contribution that counts for the Hacktoberfest Event
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants