Skip to content

Unnecessary buffers Patch #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 4, 2020
Merged

Unnecessary buffers Patch #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3cb405d
Removed Unecessary write to buffer
njfsilva Feb 4, 2014
0e51c08
Changed fileStream name since it was wrong
njfsilva Feb 4, 2014
afd29ef
Removed buffer use
njfsilva Feb 4, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 3 additions & 12 deletions jQuery-File-Upload.MVC3/Controllers/HomeController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,24 +91,15 @@ private string EncodeFile(string fileName)
private void UploadPartialFile(string fileName, HttpRequestBase request, List<ViewDataUploadFilesResult> statuses)
{
if (request.Files.Count != 1) throw new HttpRequestValidationException("Attempt to upload chunked file containing more than one fragment per request");
var file = request.Files[0];
var inputStream = file.InputStream;

var file = request.Files[0];
var fullName = Path.Combine(StorageRoot, Path.GetFileName(fileName));

using (var fs = new FileStream(fullName, FileMode.Append, FileAccess.Write))
{
var buffer = new byte[1024];

var l = inputStream.Read(buffer, 0, 1024);
while (l > 0)
{
fs.Write(buffer, 0, l);
l = inputStream.Read(buffer, 0, 1024);
}
fs.Flush();
fs.Close();
file.InputStream.CopyTo(fs);
}

statuses.Add(new ViewDataUploadFilesResult()
{
name = fileName,
Expand Down
13 changes: 2 additions & 11 deletions jQuery-File-Upload.MVC3/Upload/UploadHandler.ashx.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,16 +108,7 @@ private void UploadPartialFile(string fileName, HttpContext context, List<FilesS

using (var fs = new FileStream(fullName, FileMode.Append, FileAccess.Write))
{
var buffer = new byte[1024];

var l = inputStream.Read(buffer, 0, 1024);
while (l > 0)
{
fs.Write(buffer, 0, l);
l = inputStream.Read(buffer, 0, 1024);
}
fs.Flush();
fs.Close();
inputStream.CopyTo(fs);
}
statuses.Add(new FilesStatus(new FileInfo(fullName)));
}
Expand Down Expand Up @@ -194,4 +185,4 @@ private void ListCurrentFiles(HttpContext context)
}

}
}
}