Upgraded main aspnet core project to 2.0 #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
889d148 to
d601c79
Compare
d601c79 to
8b457a0
Compare
Author
|
My apologies for the late reply and thank you for your advice. I should have fixed all the build errors now. |
Owner
|
Are all those js/css assets not required for the example project? |
Owner
|
Great work BTW. |
Author
|
The .NET SDK automatically includes all "Content" items from the project directory by default. As a result the js/css were included twice. I ran the example project locally and the site was identical to the demo site you provided. I am glad I could help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded the Mvc.JQuery.DataTables.AspNetCore and Mvc.JQuery.DataTables.AspNetCore.Example with their dependencies to asp.net core 2.0, also fixed the issues that arose through this upgrade.