Wait for dataTables script to load #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also wait for the dataTables script to load, allows placing jquery.dataTables.js in the scripts section at the end of the layout page, to avoid needing to put the jQuery and dataTables scripts in <head>
mcintyre321
added a commit
that referenced
this pull request
Apr 15, 2014
Wait for dataTables script to load
Owner
|
I'm not convinced you want them at the end of the page though.. once they get cached they shouldn't affect performance too much, and you really want the ajax call to run asap... |
Contributor
Author
|
Thanks, so it is now possible but not advisable. I've tested and it seems like on Firefox the performance is slightly better after caching, when putting scripts in the head tag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also wait for the dataTables script to load, allows placing jquery.dataTables.js in the scripts section at the end of the layout page, to avoid needing to put the jQuery and dataTables scripts in