Initial commit of color-picker #1
Conversation
There was a problem hiding this comment.
There are a few unconverted ">" entities in the CSS file that need to be fixed. With them fixed, the tool seems to work.
I haven't reviewed the code. If that's also a condition of merging (and I suppose it should be) then I won't be able to review this for a while.
There are a couple of other things we should consider:
-
I think we thought about having "tools", as distinct from examples, live in a separate repo (e.g. "tools"), and that examples in this repo should be things whose source code could usefully be studied.
-
we decided in TO that the loading performance of interactive examples is not acceptable. I think there's a good chance this is because they are remote content being loaded into a iframe. Given that, why would we be OK replacing this MDN page with a remote-content-iframe example?
| width: 93px; | ||
| } | ||
|
|
||
| .ui-color-picker .input[data-topic="alpha"] > .name { |
There was a problem hiding this comment.
there are 11 places in this file where ">" has not been converted to ">", and this is breaking the layout.
|
I think we should close this for now. Lack of time and the solution of hosting this somewhere properly might be a different one when we really get back to this. |
No description provided.