Skip to content

Layout Cookbook - Breadcrumb example with clear intent #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

alejalapeno
Copy link

Setting the pseudo-class selector :not() paired with :first-child removes the need for separate CSS rules to achieve the same effect, but also makes your codes intent clearer by stating you want to select all list items that are not the first child.

@rachelandrew
Copy link
Collaborator

This was actually a choice made to simplify the example (in teaching I find a lot of people have little to no exposure to any complex selectors, and we're concentrating on layout here). I could go either way on it though.

@chrisdavidmills
Copy link
Contributor

I think it's good to keep examples simple, to maximize the number of people who will understand them. But I also think it's probably worth adding a note to the article to state that this is an efficiency change you could make if you were looking for optimization.

@alejalapeno, do you fancy making this change?

@avivmu
Copy link
Contributor

avivmu commented Jul 22, 2020

I updated the relevant docs - see revision change.
@chrisdavidmills If looks okay, can close this PR

@chrisdavidmills
Copy link
Contributor

Thanks @avivmu ; I've made some small updates, but this is looking good.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants