Colorpicker: modernize CSS & colors #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teoli2003
approved these changes
Mar 10, 2023
Contributor
teoli2003
left a comment
There was a problem hiding this comment.
I tested locally, and it works well. That's a nice improvement.
At some point we want to modernize the JS (without changing the structure) and fixing the indentation & co. But that's for another PR.
Moving to a grid layout and adding lab(), lch(), oklab(), hwb(), … would be a fantastic addition too.
What do you think about making it an OWD Q2 project?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated CSS to remove unneeded prefixing.
Updated CSS and JS to RGB() and HSL() from legacy RGBA() and HSLA()
Renamed HSV to HWB
was going to convert to flex/grid, but that is for a different day (though did start)