Add the space value to the options of border-image-repeat
#129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@teoli2003 Could I apply for a review from you? I hope this is not too bothering 🙏 |
Contributor
|
I tested locally and it doesn't work: space doesn't appear in the drop-down menu. (And if I'm renaming another entry, it does get renamed – so it is not my test that is wrong). |
Contributor
|
Found, we need to increase the height in the css too. |
Contributor
Author
|
@teoli2003 I just found in the updated generator page that the old values of |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #79.
This PR also aligns the order of values of
border-image-repeatto that in the spec.