-
Notifications
You must be signed in to change notification settings - Fork 841
New example: Scroll snap #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
modules/scroll_snap.html
Outdated
> | ||
</p> | ||
<p> | ||
<label><input type="checkbox" id="stop" /> Stop on all boxes</label> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this clearer?
<label><input type="checkbox" id="stop" /> Stop on all boxes</label> | |
<label><input type="checkbox" id="stop" /> disable skipping boxes</label> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or "scrolling past boxes"?
<meta name="viewport" content="width=device-width" /> | ||
<title>Scroll snap</title> | ||
<style> | ||
li { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
editor warning here about empty ruleset in case we want to add something in there, defaults, maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a JS hook.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor comments, but leaving a +1 - thanks @estelle 👍🏻
similar to https://codepen.io/estelle/pen/JjmOpvm