Skip to content

Conversation

@estelle
Copy link
Member

@estelle estelle commented May 3, 2023

@estelle estelle requested review from bsmth, dipikabh and teoli2003 May 3, 2023 23:59
>
</p>
<p>
<label><input type="checkbox" id="stop" /> Stop on all boxes</label>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this clearer?

Suggested change
<label><input type="checkbox" id="stop" /> Stop on all boxes</label>
<label><input type="checkbox" id="stop" /> disable skipping boxes</label>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or "scrolling past boxes"?

<meta name="viewport" content="width=device-width" />
<title>Scroll snap</title>
<style>
li {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

editor warning here about empty ruleset in case we want to add something in there, defaults, maybe?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a JS hook.

Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments, but leaving a +1 - thanks @estelle 👍🏻

@estelle estelle merged commit bf39396 into mdn:main May 9, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants