Skip to content

Fix content issue 28901 #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 5, 2023
Merged

Fix content issue 28901 #148

merged 2 commits into from
Sep 5, 2023

Conversation

wbamberg
Copy link
Contributor

@wbamberg wbamberg commented Sep 4, 2023

See mdn/content#28901.

The substantive change here is to remove the .preview CSS rule, that's not relevant to the downloadable version of this example and that confused the reporter of mdn/content#28901.

2 commits:

hamishwillee
hamishwillee approved these changes Sep 5, 2023
View reviewed changes
Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for splitting the prettier and removal.

@Rumyra Rumyra merged commit 4c372e6 into mdn:main Sep 5, 2023
@wbamberg wbamberg mentioned this pull request Sep 5, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Rumyra Rumyra Rumyra approved these changes

@hamishwillee hamishwillee hamishwillee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wbamberg @Rumyra @hamishwillee