-
Notifications
You must be signed in to change notification settings - Fork 843
fix(animation-frames-timing-function): replace frames() which is not a timing function #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The index page reads:
So this text is intentional. We should delete the whole example rather than edit it and the paragraph in https://github.com/mdn/css-examples/blob/main/README.md that mentions it. Paging @chrisdavidmills, as the original author ... 6 years ago ... just to confirm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am impressed that you think I'll remember work that I did 6 years ago ;-)
This is really bizarre — I'm pretty sure I'm not going mad, and that there was at one point a timing function called frames()
. But I can't find a mention of it anywhere except on these pages I wrote. It must've been introduced experimentally and then quickly abandoned.
I don't mind having an updated example with two different steps functions, or just deleting the frames()
example altogether. Either is OK, IMO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes those are the changes required
We just need to reformat the code, waiting on a reply on this comment to understand how to proceed. |
okay |
For now, I suggest you get the formatted code from this Prettier playground link. Only change from default setting is |
Add the formatted code and commit the changes? |
yes |
Format using Prettier playground link.
Oops, sorry, hadn't see your last two comments! |
You have added the formatted code right? So, everything is done then? |
Yes, all done. :) |
Thank you @madhuroshan! 🎉 |
Thank you @caugner @chrisdavidmills |
Description
In mdn/css-examples/animation-frames-timing-function/index-waa.html
In
div.animate(keyframes,options)
options object have easing function given as frames(10) but frames(10) is not a valid value of easing functions.Can't find any easing function named
frames
in mdn docs . So I replacedframes with steps (we can add others like cubic-bezier and other easing functions)
changed
var easingFunctions = ["frames(10)", "steps(10)", "ease-in"];
tovar easingFunctions = ["steps(5)", "steps(10)", "ease-in"];
Fixes #145