-
Notifications
You must be signed in to change notification settings - Fork 843
fix(css): Update rgb hsl values as per the latest syntax #158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, tnx. We might want to check in the content repo if we refer to any of these examples in this way:
in the following example, we use
rgb(1,2,3)
orrgba(1,2,3,4)
edit: indeed we need to update some places in content that reference the examples in prose.
Need update:
- Learn/CSS/CSS_layout/Positioning
- Learn/CSS/Building_blocks/Backgrounds_and_borders
- Learn/CSS/Building_blocks/Advanced_styling_effects
- Learn/CSS/CSS_layout/Media_queries
- (Walkthrough: a simple mobile-first layout)
Look okay to me:
- Learn/CSS/Building_blocks/The_box_model
- Learn/CSS/Building_blocks/Debugging_CSS
- Learn/CSS/CSS_layout/Floats_skills
- Learn/CSS/CSS_layout/Grid_skills
I think that they are missing returns at the end of some of these files. |
yeah let's add in this PR. I will commit your suggestions, tnx |
Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
I've done the rest in bfe1480 |
Thanks for reviewing, @bsmth.
Yeah, let me open a content PR alongside before merging this one |
Updated the following:
|
Merging this one now |
Updates the rgb() and a few hsl() values to follow the latest syntax:
/
).UPDATE: PR to update prose/examples in content --> mdn/content#30604