Skip to content

Conversation

@dipikabh
Copy link
Contributor

@dipikabh dipikabh commented Nov 24, 2023

Updates the rgb() and a few hsl() values to follow the latest syntax:

  • rgba -> rgb
  • Commas are omitted.
  • The alpha value is specified as a percentage separated by a slash (/).

UPDATE: PR to update prose/examples in content --> mdn/content#30604

@dipikabh dipikabh requested a review from bsmth November 24, 2023 01:07
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, tnx. We might want to check in the content repo if we refer to any of these examples in this way:

in the following example, we use rgb(1,2,3) or rgba(1,2,3,4)

edit: indeed we need to update some places in content that reference the examples in prose.

Need update:

  • Learn/CSS/CSS_layout/Positioning
  • Learn/CSS/Building_blocks/Backgrounds_and_borders
  • Learn/CSS/Building_blocks/Advanced_styling_effects
  • Learn/CSS/CSS_layout/Media_queries
    • (Walkthrough: a simple mobile-first layout)

Look okay to me:

  • Learn/CSS/Building_blocks/The_box_model
  • Learn/CSS/Building_blocks/Debugging_CSS
  • Learn/CSS/CSS_layout/Floats_skills
  • Learn/CSS/CSS_layout/Grid_skills

@teoli2003
Copy link
Contributor

I think that they are missing returns at the end of some of these files.

@bsmth
Copy link
Member

bsmth commented Nov 27, 2023

I think that they are missing returns at the end of some of these files.

yeah let's add in this PR. I will commit your suggestions, tnx

Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
@bsmth
Copy link
Member

bsmth commented Nov 27, 2023

I think that they are missing returns at the end of some of these files.

I've done the rest in bfe1480

@bsmth bsmth added the needs content update Needs update to the content to support this change. label Nov 27, 2023
@dipikabh
Copy link
Contributor Author

Thanks for reviewing, @bsmth.

edit: indeed we need to update some places in content that reference the examples in prose.

Yeah, let me open a content PR alongside before merging this one

@dipikabh
Copy link
Contributor Author

dipikabh commented Nov 28, 2023

Updated the following:

  • Learn/CSS/Building_blocks/Backgrounds_and_borders
  • Learn/CSS/Building_blocks/Advanced_styling_effects
  • Learn/CSS/Building_blocks/Values_and_units
  • Learn/CSS/CSS_layout/Media_queries
  • Learn/CSS/CSS_layout/Positioning

mdn/content#30604

@dipikabh
Copy link
Contributor Author

Merging this one now

@dipikabh dipikabh merged commit 3c6bfc2 into mdn:main Nov 28, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

needs content update Needs update to the content to support this change.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants