CSS Transforms Module Interactive Example #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 4, 2023
estelle
reviewed
Dec 6, 2023
There was a problem hiding this comment.
This is a fun demo. I think the UI could be simplified a bit, keeping it just as useful, but less busy. That would help with all the a11y features that will need to be added if we do keep all the UI elements.
The z0 doesn't get updated or change. It's helpful to know where zero is; explaining it in the text would be helpful.
Also, a toggle for backface-visibility and sliders for perspective-origin would be awesome.
estelle
requested changes
Dec 6, 2023
|
Thanks for your feedback. It should all be addressed now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(The below is copy/pasted from the Content PR's text.)
Description
Motivation
Main motivation: Improving our documentation as a part of the Interop 2023 project.
Related issues and pull requests
contentPR (for additional module prose and new guide): CSS Transforms Module Improvements content#30783css-examplesPR (for the module page's "CSS transforms in action" interactive example section): CSS Transforms Module Interactive Example #160yariPR (for sidebar changes): Add new 'buttons with CSS transforms' guide to sidebar yari#10127Once these three PRs are merged, mdn/mdn#488 will be resolved.