Skip to content

fix: various code issues #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
teoli2003 merged 13 commits into from
Dec 7, 2023
Merged

fix: various code issues #161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
d165c5b
http -> https
OnkarRuikar Dec 6, 2023
51fd57a
un used namespace
OnkarRuikar Dec 6, 2023
063c707
remove redundant `</link>` tags
OnkarRuikar Dec 6, 2023
86f49c6
fix label for attributes
OnkarRuikar Dec 6, 2023
a97fbe3
provide generic fallback fonts
OnkarRuikar Dec 6, 2023
6dd0379
remove overridden properties in same rule
OnkarRuikar Dec 6, 2023
f50882c
language issues
OnkarRuikar Dec 6, 2023
be0e69b
provide function instead of an object as argument
OnkarRuikar Dec 6, 2023
01bccbc
fix remaining closing tags
OnkarRuikar Dec 6, 2023
293039c
fix remaining closing tags
OnkarRuikar Dec 6, 2023
8960d7b
Update target-text/index.html
OnkarRuikar Dec 6, 2023
63e71da
Update target-text/index.html
OnkarRuikar Dec 6, 2023
6953bd4
Merge branch 'main' into css_code_issues
teoli2003 Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backdrop/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ function toggleFullscreen() {
if (!document.fullscreenElement) {
elem
.requestFullscreen()
.then({})
.then(() => {})
.catch((err) => {
alert(
`Error attempting to enable full-screen mode: ${err.message} (${err.name})`,
Expand Down
4 changes: 2 additions & 2 deletions counter-style-demo/css/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ body {
.header h1 {
margin: 0;
padding: 0;
font-family: Ubuntu, Arial, Tahoma, "Sans Serif";
font-family: Ubuntu, Arial, Tahoma, sans-serif;
}

.header {
Expand All @@ -41,7 +41,7 @@ body {
.notes-section {
margin: 10px;
color: #4d4e53;
font-family: Ubuntu, Arial, Tahoma, "Sans Serif";
font-family: Ubuntu, Arial, Tahoma, sans-serif;
float: left;
}

Expand Down
2 changes: 1 addition & 1 deletion css-cookbook/sharp-account_box-24px.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 1 addition & 2 deletions editable-samples-2/pages/filter/svg/example.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
8 changes: 4 additions & 4 deletions editable-samples/codemirror/mode/css/gss.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,17 @@

<title>CodeMirror: Closure Stylesheets (GSS) mode</title>
<meta charset="utf-8"/>
<link rel=stylesheet href="../../doc/docs.css">
<link rel=stylesheet href="../../doc/docs.css" />

<link rel="stylesheet" href="../../lib/codemirror.css">
<link rel="stylesheet" href="../../addon/hint/show-hint.css">
<link rel="stylesheet" href="../../lib/codemirror.css" />
<link rel="stylesheet" href="../../addon/hint/show-hint.css" />
<script src="../../lib/codemirror.js"></script>
<script src="css.js"></script>
<script src="../../addon/hint/show-hint.js"></script>
<script src="../../addon/hint/css-hint.js"></script>
<style>.CodeMirror {background: #f8f8f8;}</style>
<div id=nav>
<a href="http://codemirror.net"><h1>CodeMirror</h1><img id=logo src="../../doc/logo.png"></a>
<a href="https://codemirror.net"><h1>CodeMirror</h1><img id=logo src="../../doc/logo.png"></a>

<ul>
<li><a href="../../index.html">Home</a>
Expand Down
8 changes: 4 additions & 4 deletions editable-samples/codemirror/mode/css/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,17 @@

<title>CodeMirror: CSS mode</title>
<meta charset="utf-8"/>
<link rel=stylesheet href="../../doc/docs.css">
<link rel=stylesheet href="../../doc/docs.css" />

<link rel="stylesheet" href="../../lib/codemirror.css">
<link rel="stylesheet" href="../../addon/hint/show-hint.css">
<link rel="stylesheet" href="../../lib/codemirror.css" />
<link rel="stylesheet" href="../../addon/hint/show-hint.css" />
<script src="../../lib/codemirror.js"></script>
<script src="css.js"></script>
<script src="../../addon/hint/show-hint.js"></script>
<script src="../../addon/hint/css-hint.js"></script>
<style>.CodeMirror {background: #f8f8f8;}</style>
<div id=nav>
<a href="http://codemirror.net"><h1>CodeMirror</h1><img id=logo src="../../doc/logo.png"></a>
<a href="https://codemirror.net"><h1>CodeMirror</h1><img id=logo src="../../doc/logo.png"></a>

<ul>
<li><a href="../../index.html">Home</a>
Expand Down
6 changes: 3 additions & 3 deletions editable-samples/codemirror/mode/css/less.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@

<title>CodeMirror: LESS mode</title>
<meta charset="utf-8"/>
<link rel=stylesheet href="../../doc/docs.css">
<link rel=stylesheet href="../../doc/docs.css" />

<link rel="stylesheet" href="../../lib/codemirror.css">
<link rel="stylesheet" href="../../lib/codemirror.css" />
<script src="../../lib/codemirror.js"></script>
<script src="../../addon/edit/matchbrackets.js"></script>
<script src="css.js"></script>
<style>.CodeMirror {border: 1px solid #ddd; line-height: 1.2;}</style>
<div id=nav>
<a href="http://codemirror.net"><h1>CodeMirror</h1><img id=logo src="../../doc/logo.png"></a>
<a href="https://codemirror.net"><h1>CodeMirror</h1><img id=logo src="../../doc/logo.png"></a>

<ul>
<li><a href="../../index.html">Home</a>
Expand Down
6 changes: 3 additions & 3 deletions editable-samples/codemirror/mode/css/scss.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@

<title>CodeMirror: SCSS mode</title>
<meta charset="utf-8"/>
<link rel=stylesheet href="../../doc/docs.css">
<link rel=stylesheet href="../../doc/docs.css" />

<link rel="stylesheet" href="../../lib/codemirror.css">
<link rel="stylesheet" href="../../lib/codemirror.css" />
<script src="../../lib/codemirror.js"></script>
<script src="css.js"></script>
<style>.CodeMirror {background: #f8f8f8;}</style>
<div id=nav>
<a href="http://codemirror.net"><h1>CodeMirror</h1><img id=logo src="../../doc/logo.png"></a>
<a href="https://codemirror.net"><h1>CodeMirror</h1><img id=logo src="../../doc/logo.png"></a>

<ul>
<li><a href="../../index.html">Home</a>
Expand Down
12 changes: 6 additions & 6 deletions editable-samples/pages/border-top-color/index-old.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@
<head>
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width" />
<link href="../../css/editable-old.css" rel="stylesheet"></link>
<link href="../../css/editable-old.css" rel="stylesheet" />

<link href="../../codemirror/lib/codemirror.css" rel="stylesheet">
<link href="../../codemirror/theme/mdn-like.css" rel="stylesheet"></link>
<link href="../../codemirror/addon/hint/show-hint.css" rel="stylesheet"></link>
<link href="../../codemirror/lib/codemirror.css" rel="stylesheet" />
<link href="../../codemirror/theme/mdn-like.css" rel="stylesheet" />
<link href="../../codemirror/addon/hint/show-hint.css" rel="stylesheet" />

<link href="css/element.css" rel="stylesheet"></link>
<link href="css/element.css" rel="stylesheet" />
</head>

<body>
Expand All @@ -31,7 +31,7 @@
<script src="../../codemirror/mode/css/css.js"></script>
<script src="../../codemirror/addon/hint/css-hint.js"></script>
<script src="../../codemirror/addon/hint/show-hint.js"></script>

<script src="js/border-top-color.js"></script>
<script src="../../js/editable-old.js"></script>
</body>
Expand Down
12 changes: 6 additions & 6 deletions editable-samples/pages/border-top-color/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@
<head>
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width" />
<link href="../../css/editable.css" rel="stylesheet"></link>
<link href="../../css/editable.css" rel="stylesheet" />

<link href="../../codemirror/lib/codemirror.css" rel="stylesheet">
<link href="../../codemirror/theme/eclipse.css" rel="stylesheet"></link>
<link href="../../codemirror/addon/hint/show-hint.css" rel="stylesheet"></link>
<link href="../../codemirror/lib/codemirror.css" rel="stylesheet" />
<link href="../../codemirror/theme/eclipse.css" rel="stylesheet" />
<link href="../../codemirror/addon/hint/show-hint.css" rel="stylesheet" />

<link href="css/element.css" rel="stylesheet"></link>
<link href="css/element.css" rel="stylesheet" />
</head>

<body>
Expand All @@ -30,7 +30,7 @@
<script src="../../codemirror/mode/css/css.js"></script>
<script src="../../codemirror/addon/hint/css-hint.js"></script>
<script src="../../codemirror/addon/hint/show-hint.js"></script>

<script src="js/border-top-color.js"></script>
<script src="../../js/editable.js"></script>
</body>
Expand Down
3 changes: 1 addition & 2 deletions flexbox/use-cases/MDN.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion font-features/font-variant-alternates.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
}

.script {
font-family: "Dancing Script";
font-family: "Dancing Script", serif;
}

.wrapper {
Expand Down
2 changes: 1 addition & 1 deletion font-features/font-variant-numeric-example.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

.ordinal {
font-variant-numeric: ordinal;
font-family: "Source Sans Pro";
font-family: "Source Sans Pro", sans-serif;
}
</style>
</head>
Expand Down
2 changes: 1 addition & 1 deletion learn/getting-started--download.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ <h1>I am a level one heading</h1>
<p>
This is a paragraph of text. In the text is a
<span>span element</span> and also a
<a href="http://example.com">link</a>.
<a href="https://example.com">link</a>.
</p>

<p>
Expand Down
2 changes: 1 addition & 1 deletion learn/getting-started/biog-download.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ <h2>Contact information</h2>
</li>
<li>
Web:
<a href="http://example.com">http://example.com</a>
<a href="https://example.com">https://example.com</a>
</li>
<li>Tel: 123 45678</li>
</ul>
Expand Down
2 changes: 1 addition & 1 deletion learn/getting-started/biog.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ <h1>Jane Doe</h1>
<h2>Contact information</h2>
<ul>
<li>Email: <a href="mailto:jane@example.com">jane@example.com</a></li>
<li>Web: <a href="http://example.com">http://example.com</a></li>
<li>Web: <a href="https://example.com">https://example.com</a></li>
<li>Tel: 123 45678</li>
</ul>
</section>
Expand Down
2 changes: 1 addition & 1 deletion learn/getting-started/started1.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ <h1>I am a level one heading</h1>
<p>
This is a paragraph of text. In the text is a
<span>span element</span> and also a
<a href="http://example.com">link</a>.
<a href="https://example.com">link</a>.
</p>

<p>
Expand Down
2 changes: 1 addition & 1 deletion learn/getting-started/started2.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ <h1>I am a level one heading</h1>
<p>
This is a paragraph of text. In the text is a
<span>span element</span> and also a
<a href="http://example.com">link</a>.
<a href="https://example.com">link</a>.
</p>

<p>
Expand Down
2 changes: 1 addition & 1 deletion learn/getting-started/started3.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ <h1>I am a level one heading</h1>
<p>
This is a paragraph of text. In the text is a
<span>span element</span> and also a
<a href="http://example.com">link</a>.
<a href="https://example.com">link</a>.
</p>

<p>
Expand Down
2 changes: 1 addition & 1 deletion learn/selectors/attribute-links.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
<ul>
<li><a href="https://example.com">Link 1</a></li>
<li>
<a href="http://example.com" title="Visit example.com">Link 2</a>
<a href="https://example.com" title="Visit example.com">Link 2</a>
</li>
<li><a href="/contact">Link 3</a></li>
<li><a href="../contact/index.html">Link 4</a></li>
Expand Down
2 changes: 1 addition & 1 deletion learn/tasks/float/marking.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ In task 2 we check that the student understands how to clear an element from a f

## Task 3

In the final task the student is asked to use the most up to date method of clearing the box underneath the floated item. Therefore they should add `display: flow-root` to the class for `.box`. Other methods might be to use `overflow` or a clearfix hack, however the learning materials detail the `flow-root` method as the modern way to achieve this.
In the final task the student is asked to use the most up-to-date method of clearing the box underneath the floated item. Therefore they should add `display: flow-root` to the class for `.box`. Other methods might be to use `overflow` or a clearfix hack, however the learning materials detail the `flow-root` method as the modern way to achieve this.

```
.box {
Expand Down
2 changes: 1 addition & 1 deletion learn/tasks/selectors/attribute-links-download.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
<a href="https://example.com">Link 1</a>
</li>
<li>
<a href="http://example.com" title="Visit example.com">Link 2</a>
<a href="https://example.com" title="Visit example.com">Link 2</a>
</li>
<li>
<a href="/contact">Link 3</a>
Expand Down
2 changes: 1 addition & 1 deletion learn/tasks/selectors/attribute-links.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
<ul>
<li><a href="https://example.com">Link 1</a></li>
<li>
<a href="http://example.com" title="Visit example.com">Link 2</a>
<a href="https://example.com" title="Visit example.com">Link 2</a>
</li>
<li><a href="/contact">Link 3</a></li>
<li><a href="../contact/index.html">Link 4</a></li>
Expand Down
2 changes: 1 addition & 1 deletion learn/tasks/selectors/pseudo.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
<section class="preview">
<div class="container">
<p>
Veggies es <a href="http://example.com">bonus vobis</a>, proinde vos
Veggies es <a href="https://example.com">bonus vobis</a>, proinde vos
postulo essum magis kohlrabi welsh onion daikon amaranth tatsoi
tomatillo melon azuki bean garlic.
</p>
Expand Down
2 changes: 1 addition & 1 deletion logical/size-max.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
<div class="container">
<div class="physical box">I have a max-width of 200px.</div>

<div class="logical box">I have an max-inline-size of 200px.</div>
<div class="logical box">I have a max-inline-size of 200px.</div>
</div>
</section>

Expand Down
3 changes: 1 addition & 2 deletions masking/MDN.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 1 addition & 2 deletions masking/star.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 0 additions & 1 deletion scroll-snap/mandatory-y-old-spec.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
scroll-snap-points-y: repeat(320px);
scroll-snap-destination: 0 0;
scroll-snap-type: y mandatory;
scroll-snap-type: mandatory;
}

.scroller section {
Expand Down
5 changes: 1 addition & 4 deletions tools/border-image-generator/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,9 +194,7 @@
margin: 0;
padding: 0 0.3em;

border: 3px solid #3490d2;
border-color: #208b20;
background: #666;
border: 3px solid #208b20;
background-color: #eef1f5;
color: #000;

Expand Down Expand Up @@ -889,7 +887,6 @@ body[data-move="Y"] {
text-align: center;
color: #555;

position: absolute;
z-index: 1000;

box-shadow: 0 0 3px 0 #bababa;
Expand Down
1 change: 0 additions & 1 deletion tools/border-radius-generator/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,7 +520,6 @@ body {
margin: 0;
padding: 0 0 0 10px;
background: #555;
border: 1px solid #555;
border: none;
color: #fff;
float: left;
Expand Down
Loading