feat: add 'copy css' button to tools/border-image-generator #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `mousedown` triggers for both right and middle-clicks, which does not align with the UX of a button. `onclick` is a more 'canonical' option.
pepelsbey
approved these changes
May 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds a 'click to copy' button to the CSS code output of the Border Image Generator tool.
Motivation:
I'm proposing this change as it improves the QOL of the border image tool, especially when rapidly iterating various options for border images. The copy button is out of the way and shouldn't interfere with any existing workflows.
Additional details:
Related issues and pull requests:
This is my first PR to
mdn/css-examples(or, anymdnrepository), so I apologize if I've missed any contributing steps! Let me know if there's any issues - I'm happy to make any necessary changes :)