fix: update border-image-slice value when fill is toggled (fixes #63)
#175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR updates the Border Image Generator tool, fixing a bug where the CSS code output is not updated when the fill checkbox is toggled.
Motivation:
Before this PR, the "CSS Code" section of the tool would not update the
border-image-sliceproperty when the fill value is toggled. This can lead to an inconsistency between given inputs and the resulting outputs. This PR fixes that by callingsetOutputCSSinside thesetBorderFillfunction, bringing it in-line with the behaviour of thesetBorderSlicefunction.Additional details:
Related issues and pull requests:
border-image-slicefillkeyword not toggled in CSS output #63 references this problem, which is fixed and can be closed by this PR.