Skip to content

Conversation

@OnkarRuikar
Copy link
Contributor

@OnkarRuikar OnkarRuikar commented Jul 1, 2024

When the output text wraps the controls get pushed down:

colorMixer-2024-07-01_18.28.25.mp4

Solution

Increase output text height.

@OnkarRuikar OnkarRuikar requested a review from a team as a code owner July 1, 2024 13:00
@OnkarRuikar OnkarRuikar requested review from pepelsbey and removed request for a team July 1, 2024 13:00
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also do this if you want to get rid of the janky values at integers:

        percentageOne.addEventListener("input", (e) => {
          let valueFixed = parseFloat(e.target.value).toFixed(1);
          percentageOneLabel.innerText = valueFixed + "%";
          updateColorMix();
        });
        percentageTwo.addEventListener("input", (e) => {
          let valueFixed = parseFloat(e.target.value).toFixed(1);
          percentageTwoLabel.innerText = valueFixed + "%";
          updateColorMix();
        });

Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving anyway, LGTM 👍🏻

@bsmth bsmth merged commit f1fc4fe into mdn:main Jul 1, 2024
@OnkarRuikar OnkarRuikar deleted the patch-1 branch July 2, 2024 05:58
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants