Skip to content

use new syntax for CSS color function values #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 9, 2024
Merged

use new syntax for CSS color function values #196

merged 2 commits into from
Sep 9, 2024

Conversation

OnkarRuikar
Copy link
Contributor

The PR converts old style rgb() and hsl() syntax to the new, without comma, syntax.

@OnkarRuikar OnkarRuikar requested a review from a team as a code owner August 28, 2024 04:10
@OnkarRuikar OnkarRuikar requested review from pepelsbey and removed request for a team August 28, 2024 04:10
@OnkarRuikar OnkarRuikar mentioned this pull request Aug 28, 2024
Merged
pepelsbey
pepelsbey approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you :)

Giving you the chance to merge it in case you need to sync it with other content.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024

This pull request has merge conflicts that must be resolved before it can be merged.

@bsmth bsmth merged commit 82dc5e6 into mdn:main Sep 9, 2024
1 check passed
@OnkarRuikar OnkarRuikar deleted the newcolor_syntax branch September 9, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepelsbey pepelsbey pepelsbey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OnkarRuikar @pepelsbey @bsmth