Skip to content

Adding a missing solution for an additional question #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2020

Conversation

avivmu
Copy link
Contributor

@avivmu avivmu commented Jul 21, 2020

In https://developer.mozilla.org/en-US/docs/Learn/CSS/CSS_layout/Grid_skills#Grid_Layout_Two there is an additional question:

Can you now cause the first item to display on top without changing the order of items in the source?

I thought it would be useful to add at least one acceptable solution.
I admit that my text might be improved, as I was focusing more on the solution itself.
@chrisdavidmills I mention you because otherwise no one will approve/deny this

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@avivmu thanks for providing a solution for this question. This is looking pretty good; I just had a few comments/suggestions:

  1. Since the default order value is 0, you only need the first rule, and can remove the second one.
  2. Maybe also show an alternative solution using z-index?
  3. You need to put a space in between ### and Additional question for the markdown to render properly.

@avivmu
Copy link
Contributor Author

avivmu commented Jul 22, 2020

Updated with your comments

@chrisdavidmills chrisdavidmills merged commit bfac031 into mdn:master Jul 22, 2020
@chrisdavidmills
Copy link
Contributor

thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants