Fix for sticky footer examples in article not actually being sticky #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks @BassOfBass , this is a good thing to spot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not very obvious, but the previews are set up in a hacky way and thus are only "sticky" within their, quite small, window. It's however pretty glaring in downloadable examples. Not sure how to fix the previews and the article itself yet, since setting up sticky footers requires more than
min-height: 100%on the footer's parent. Basically for relative values to work the parent has to have known height values. In context of global sticky footers it means all footer's parent's parents(<html>included) have to haveheight: 100%.