add cross browser support for image-set() css ref in alternative image formats example #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e formats example
Contributor
Author
|
@teoli2003 Can you review this? |
rachelandrew
suggested changes
Sep 13, 2021
Collaborator
rachelandrew
left a comment
There was a problem hiding this comment.
You need to repeat any change inside the textarea or it will be overwritten onload.
These are very easy to test by opening them in a browser.
Contributor
Author
Is this correct now?
How can I do this can you please elaborate? |
Contributor
Author
|
Hi @rachelandrew, I waiting for your re-review of this pr. |
Collaborator
|
To open a file in a browser? Double click the file icon, it will open in the browser. |
images/image-set-type.html
Outdated
| <div class="box"></div> | ||
| </section> | ||
|
|
||
| <textarea class="playable playable-css" style="height: 150px;"> |
Collaborator
There was a problem hiding this comment.
Have you tested that this does not cause a scrollbar? I think height: 150px will not be tall enough for people to see the code.
digi-booster
commented
Sep 25, 2021
rachelandrew
approved these changes
Sep 28, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e formats example